Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move code examples into slider migration to match other files and fix… #27689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

move code examples into slider migration to match other files and fix… #27689

wants to merge 2 commits into from
+158 −190

Conversation

micahgodbolt
Copy link
Member

slider migration docs did not align with the rest of the migration docs, and it seems they were not set up to render v8 components anyway, so this fixes a render bug and gets the docs in better alignment.

@micahgodbolt micahgodbolt requested review from a team as code owners April 25, 2023 14:23
@micahgodbolt micahgodbolt requested a review from ling1726 April 25, 2023 14:23
@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 25, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 25, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3410441:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 25, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d80eca9d508c9a8afe4b461d56fb172cd2d557b5 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 25, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against d80eca9d508c9a8afe4b461d56fb172cd2d557b5

@tudorpopams tudorpopams self-requested a review April 26, 2023 12:14
@ling1726
Copy link
Member

@micahgodbolt I don't see the Slider stories in the demo docsite https://fluentuipr.z22.web.core.windows.net/pull/27689/public-docsite-v9/storybook/index.html?path=/docs/concepts-introduction--page

@Hotell
Copy link
Contributor

Hotell commented May 3, 2023 •
edited
Loading

@ling1726

@micahgodbolt I don't see the Slider stories in the demo docsite https://fluentuipr.z22.web.core.windows.net/pull/27689/public-docsite-v9/storybook/index.html?path=/docs/concepts-introduction--page

https://fluentuipr.z22.web.core.windows.net/pull/27689/public-docsite-v9/storybook/index.html?path=/docs/concepts-migration-from-v8-components-slider-migration--page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudorpopams tudorpopams tudorpopams approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@ling1726 ling1726 Awaiting requested review from ling1726

Assignees

@ling1726 ling1726

Labels
Area: Website
Projects
None yet
Milestone
April Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
6 participants
@micahgodbolt @fabricteam @ling1726 @Hotell @tudorpopams @msft-fluent-ui-bot